Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2324/ Admin UI should accept queryParam to route to details or list editor view #2327

Merged
merged 7 commits into from
Apr 2, 2024
Merged

#2324/ Admin UI should accept queryParam to route to details or list editor view #2327

merged 7 commits into from
Apr 2, 2024

Conversation

Abhinegi2
Copy link
Contributor

@Abhinegi2 Abhinegi2 commented Mar 29, 2024 •
edited
Loading

closes: #2324

Description of changes

  • Added query parameters into the routes to entity details and list screen.
  • Create a function in the AdminEntityComponent to retrieve details from the query parameters.
  • Utilize the mode property to set the modes.
  • Empty the params when users coming from specific screen

@Abhinegi2 Abhinegi2 self-assigned this Mar 29, 2024
@github-actions GitHub Actions
Copy link

Deployed to https://pr-2327.aam-digital.net/

@Abhinegi2 Abhinegi2 marked this pull request as ready for review April 1, 2024 13:29
@Abhinegi2 Abhinegi2 requested a review from sleidig April 1, 2024 13:29
sleidig
sleidig requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, just needs fixed test dependencies

src/app/core/admin/admin-entity/admin-entity.component.ts Show resolved Hide resolved
src/app/core/admin/admin-entity/admin-entity.component.ts Outdated Show resolved Hide resolved
@Abhinegi2
Copy link
Contributor Author

works well, just needs fixed test dependencies

@sleidig fixed the test dependencies.

@Abhinegi2 Abhinegi2 requested a review from sleidig April 2, 2024 10:45
@sleidig sleidig merged commit 647733e into master Apr 2, 2024
7 checks passed
@sleidig sleidig deleted the feature/added-query-params-to-route branch April 2, 2024 11:52
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.34.2-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Apr 2, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.34.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees

@Abhinegi2 Abhinegi2

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin UI should accept queryParam to route to details or list editor view
3 participants
@Abhinegi2 @aam-digital-ci @sleidig